Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate the gopath hacks to allow for codegen anywhere. #10245

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Integrate the gopath hacks to allow for codegen anywhere. #10245

merged 1 commit into from
Dec 3, 2020

Conversation

n3wscott
Copy link
Contributor

@n3wscott n3wscott commented Dec 2, 2020

Proposed Changes

  • Use GOPATH hacks to codegen anywhere.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 2, 2020
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #10245 (7998a7d) into master (afc3c0d) will decrease coverage by 0.01%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10245      +/-   ##
==========================================
- Coverage   88.13%   88.11%   -0.02%     
==========================================
  Files         184      184              
  Lines        8606     8619      +13     
==========================================
+ Hits         7585     7595      +10     
- Misses        785      788       +3     
  Partials      236      236
Impacted Files Coverage Δ
pkg/reconciler/route/traffic/rollout.go 96.59% <50.00%> (-3.41%) ⬇️
pkg/reconciler/revision/background.go 95.18% <100.00%> (+0.30%) ⬆️
pkg/reconciler/route/reconcile_resources.go 86.40% <100.00%> (+0.40%) ⬆️
pkg/reconciler/route/traffic/traffic.go 94.21% <100.00%> (+0.06%) ⬆️
pkg/activator/net/revision_backends.go 90.49% <0.00%> (-0.91%) ⬇️
pkg/reconciler/autoscaling/kpa/scaler.go 90.00% <0.00%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc3c0d...41cda22. Read the comment docs.

@n3wscott
Copy link
Contributor Author

n3wscott commented Dec 2, 2020

/retest

This was referenced Dec 2, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
julz
julz reviewed Dec 2, 2020
View reviewed changes
Copy link
Member

@julz julz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥰 yay!

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@n3wscott
Copy link
Contributor Author

n3wscott commented Dec 2, 2020

/retest

@vagababov
Copy link
Contributor

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
@knative-prow-robot knative-prow-robot merged commit 8813e5c into knative:master Dec 3, 2020
@julz julz mentioned this pull request Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julz julz julz left review comments

@coryrc coryrc Awaiting requested review from coryrc

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@julz julz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@n3wscott @vagababov @knative-prow-robot @julz